Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Automation in Windows Console: Remove deprecated isImprovedTextRangeAvailable #12955

Merged
merged 3 commits into from Oct 19, 2021
Merged

UI Automation in Windows Console: Remove deprecated isImprovedTextRangeAvailable #12955

merged 3 commits into from Oct 19, 2021

Conversation

codeofdusk
Copy link
Contributor

@codeofdusk codeofdusk commented Oct 18, 2021 •
edited by seanbudd

Link to issue number:

None, merge once 2022.1 dev cycle starts.

Summary of the issue:

WinConsoleUIA.isImprovedTextRangeAvailable was deprecated in #12660 in favour of API levels.

Description of how this pull request fixes the issue:

Remove deprecated property.

Testing strategy:

Tested that UIA console still functions.

Known issues with pull request:

None known.

Change log entries:

== Changes for Developers ==

  • NVDAObjects.UIA.winConsoleUIA.WinConsoleUIA.isImprovedTextRangeAvailable has been removed. Use apiLevel instead.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@codeofdusk codeofdusk requested a review from a team as a code owner October 18, 2021 18:17
@seanbudd seanbudd added this to the 2022.1 milestone Oct 18, 2021
@codeofdusk
Copy link
Contributor Author

This PR is no longer blocked.

@seanbudd seanbudd merged commit a54b530 into nvaccess:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees
No one assigned
Labels
api-breaking-change
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codeofdusk @seanbudd